Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot support on supervisor #3062

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Snapshot support on supervisor #3062

wants to merge 1 commit into from

Conversation

sipriyaa
Copy link
Contributor

@sipriyaa sipriyaa commented Sep 24, 2024 •
edited
Loading

What this PR does / why we need it:
This PR includes existing snapshot-related code changes and additions to support snapshots on Supervisor components such as PodVM, VM Service, Stretched Supervisor, and Multi SVC.

Testing done:
Yes

Supervisor Logs:

supervisor-logs.txt

Lint Check:
sipriya@C02CR8ENMD6M vsphere-csi-driver % golangci-lint run --enable=lll
sipriya@C02CR8ENMD6M vsphere-csi-driver % make golangci-lint
hack/check-golangci-lint.sh
golangci/golangci-lint info checking GitHub for tag 'v1.59.1'
golangci/golangci-lint info found version: 1.59.1 for v1.59.1/darwin/amd64
golangci/golangci-lint info installed /Users/sipriya/go/bin/golangci-lint
INFO golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z
INFO [config_reader] Config search paths: [./ /Users/sipriya/snapshot-supervisor-support-set1/vsphere-csi-driver /Users/sipriya/snapshot-supervisor-support-set1 /Users/sipriya /Users /]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 8 linters: [errcheck gosimple govet ineffassign lll misspell staticcheck unused]
INFO [loader] Go packages loading at mode 575 (compiled_files|exports_file|imports|name|deps|files|types_sizes) took 1m3.638701092s
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 425.612542ms

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 24, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 24, 2024
@sipriyaa sipriyaa force-pushed the snapshot-supervisor-support-set1 branch 10 times, most recently from f55fac9 to 84f3b09 Compare October 2, 2024 17:26
@sipriyaa sipriyaa force-pushed the snapshot-supervisor-support-set1 branch 4 times, most recently from 5c9c6a1 to af59ec0 Compare October 15, 2024 06:00
@sipriyaa sipriyaa force-pushed the snapshot-supervisor-support-set1 branch from c1ed874 to 9bf7cf2 Compare October 17, 2024 17:22
@sipriyaa sipriyaa changed the title <WIP> Snapshot support on supervisor Snapshot support on supervisor Oct 17, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2024
@kavyashree-r
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavyashree-r, sipriyaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sipriyaa sipriyaa force-pushed the snapshot-supervisor-support-set1 branch 2 times, most recently from 00cd63d to 662ce86 Compare October 18, 2024 09:08
@sipriyaa sipriyaa force-pushed the snapshot-supervisor-support-set1 branch from c0a4254 to a90d979 Compare October 18, 2024 10:29
@sipriyaa sipriyaa force-pushed the snapshot-supervisor-support-set1 branch from 13fea09 to 5852883 Compare October 18, 2024 10:32
@k8s-ci-robot
Copy link
Contributor

@sipriyaa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-vsphere-csi-driver-verify-golangci-lint 5852883 link true /test pull-vsphere-csi-driver-verify-golangci-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rajguptavm
rajguptavm reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@rajguptavm rajguptavm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

tests/e2e/csi_snapshot_basic.go

Test Steps:
==========
1. Read Storage Class "shared-ds-policy-1571".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any specific SC to use here??

tests/e2e/snapshot_stretched_supervisor.go
framework.Failf("Unable to find ready and schedulable Node")
}

// delete nginx service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the comment

tests/e2e/snapshot_vmservice_vm.go
dsRef.Value, GetAndExpectStringEnvVar(envContentLibraryUrlSslThumbprint))

/*
[ ~ ]# kubectl get vmclass -n csi-vmsvcns-2227
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I have intentionally left these comments because the VM service feature is new to everyone. The comments provide context on what each code block is doing and how to verify it on the backend. This helps the end user understand the end-to-end VM service code flow.

I'm leaving this comment open because I want to understand why you're asking me to remove it.

tests/e2e/snapshot_vmservice_vm.go Show resolved Hide resolved
tests/e2e/snapshot_vmservice_vm.go Show resolved Hide resolved
tests/e2e/snapshot_vmservice_vm.go Show resolved Hide resolved
tests/e2e/snapshot_vmservice_vm.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajguptavm rajguptavm rajguptavm left review comments

@divyenpatel divyenpatel Awaiting requested review from divyenpatel

@kavyashree-r kavyashree-r Awaiting requested review from kavyashree-r

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sipriyaa @kavyashree-r @k8s-ci-robot @rajguptavm